Wrong implementation of strncpy

[rothfussthomas]

Hi,

there's following example code running under Windows:

UaDateTime date_time;
UaString s;
s = date_time.toString ();

Therefore dwLowDateTime and dwHighDateTime are 0.
Within ...uastackplatformswin32_v6opcua_p_datetime.c following function is called:

OpcUa_P_String_strncpy(a_pBuffer, a_uLength, OPCUA_P_DATETIME_EARLIEST, (OpcUa_UInt32)strlen(OPCUA_P_DATETIME_EARLIEST));

Within ...uastackplatformswin32_v6opcua_p_string.c the function OpcUa_P_String_strncpy is called and then

if(strncpy(a_strDestination, a_strSource, a_uiLength) != a_strDestination)

a_uiLength is 24. This means that there's no trailing '0' inserted since a_uiLength is equal to the length of the string. The description of strncpy of the Microsoft Help says: "If count is greater than the length of strSource, the destination string is padded with null characters up to length count."

a_uiLength should be replaced by a_uiDestSize

Best Regards,
Thomas

[Support Team]

Hi Thomas,

Thank you for reporting this issue.

This is a known issue that was already fixed. The fix will be contained in the next service release 1.3.2 we are currently working on.

Please contact support@unifiedautomation.com if you need this single patch earlier.

Best Regards,
Unified Automation Support Team

[Support Team]

Hi,

The new service release for the C++ SDK (V1.3.2) is now available for download

http://www.unified-automation.com/opc-ua-servers/

Best Regards,
Unified Automation Support Team